Search current folder for discid.dll #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows Python 3.8+ only Fixes JonnyJD#143
jesus2099
force-pushed
the
search-current-folder-for-discid.dll
branch
from
c310d72 to
07edba3
Compare
|
Woops, I created the PR at the wrong place. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This JonnyJD#125 fix from @omgitsraven was NG for Python 3.7 and less, OK only for Python 3.8+.
I found how to test Python version with https://stackoverflow.com/a/3016198/2236179
I will also test on Linux to see if it hinders non-Windows, and update my PR, if so.